Skip to content

chore: Remove unused Python json modules#731

Merged
childish-sambino merged 2 commits intosendgrid:masterfrom
gy741:clean_python_module
Mar 6, 2020
Merged

chore: Remove unused Python json modules#731
childish-sambino merged 2 commits intosendgrid:masterfrom
gy741:clean_python_module

Conversation

@gy741
Copy link
Copy Markdown
Contributor

@gy741 gy741 commented Oct 31, 2018

Fixes

Hello,

In my opinion, No json module are required.

The json module is not used.

What do you think of it?

Thanks.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2018 •
edited
Loading

Codecov Report

Merging #731 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          70       70           
  Lines        2303     2303           
  Branches      338      338           
=======================================
  Hits         1898     1898           
  Misses        206      206           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abbf58...2175605. Read the comment docs.

@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Nov 2, 2018

Hello @gy741,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@gy741
Copy link
Copy Markdown
Contributor Author

gy741 commented Nov 3, 2018

Thanks @thinkingserious
I just joined in this form :)

@childish-sambino childish-sambino changed the title Remove unused Python json modules chore: Remove unused Python json modules Mar 6, 2020
@childish-sambino childish-sambino merged commit 0bc6ad8 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gy741 @thinkingserious @childish-sambino